Conversation
…time that are not needed except for the EVCharger class (done after GSYE-915)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1910 +/- ##
==========================================
+ Coverage 70.99% 71.12% +0.12%
==========================================
Files 149 149
Lines 14109 14122 +13
Branches 1881 1872 -9
==========================================
+ Hits 10017 10044 +27
+ Misses 3572 3548 -24
- Partials 520 530 +10 🚀 New features to boost your workflow:
|
spyrostz
reviewed
Jan 6, 2026
src/gsy_e/models/strategy/storage.py
Outdated
Comment on lines
276
to
279
| energy_rate_increase_per_update, | ||
| energy_rate_decrease_per_update, | ||
| bid_fit_to_limit, | ||
| offer_fit_to_limit, |
Member
There was a problem hiding this comment.
For completion, why not adding types to those too? These are the ones right?
energy_rate_increase_per_update: StrategyProfileBase,
energy_rate_decrease_per_update: StrategyProfileBase,
bid_fit_to_limit: bool,
offer_fit_to_limit: bool,
Member
Author
There was a problem hiding this comment.
yes, forgot to complete this. Will do!
spyrostz
reviewed
Jan 6, 2026
| self.event_activate_energy() | ||
| self.event_activate_price() | ||
|
|
||
| def _validate_constructor_arguments( # pylint: disable=too-many-arguments, too-many-branches |
Member
There was a problem hiding this comment.
I assume that this method was replaced by the gsy-framework validator methods, that's why it was removed ?
Member
Author
There was a problem hiding this comment.
Yes, all is validated by the StorageValidator and this method was not called anywhere. I guess somebody forgot to remove it back then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=feature/GSYE-884
GSY_FRAMEWORK_BRANCH=master
SCM_ENGINE_BRANCH=master